Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 302 redirects where the Location is a relative location path #630

Closed
wants to merge 2 commits into from
Closed

Add support for 302 redirects where the Location is a relative location path #630

wants to merge 2 commits into from

Conversation

DilumAluthge
Copy link
Member

@DilumAluthge DilumAluthge commented Nov 27, 2020

This pull request depends on JuliaWeb/URIs.jl#13

@DilumAluthge DilumAluthge marked this pull request as draft November 27, 2020 01:39
@DilumAluthge DilumAluthge changed the title Add support for 302 redirects where the Location: is a relative location path Add support for 302 redirects where the Location is a relative location path Nov 27, 2020
@codecov-io
Copy link

codecov-io commented Nov 27, 2020

Codecov Report

Merging #630 (b7b535f) into master (0391458) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #630      +/-   ##
==========================================
- Coverage   77.46%   77.33%   -0.14%     
==========================================
  Files          36       36              
  Lines        2299     2299              
==========================================
- Hits         1781     1778       -3     
- Misses        518      521       +3     
Impacted Files Coverage Δ
src/RedirectRequest.jl 72.00% <100.00%> (ø)
src/ConnectionRequest.jl 50.00% <0.00%> (-1.79%) ⬇️
src/Servers.jl 65.56% <0.00%> (-1.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0391458...b7b535f. Read the comment docs.

@DilumAluthge
Copy link
Member Author

Turns out we probably don't need this. I think we can do everything in JuliaWeb/URIs.jl#13

@DilumAluthge DilumAluthge deleted the dpa/302-redirect-relative-uris branch November 27, 2020 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants